feat: v61 in-app widgets (sheets + grid)#573
Conversation
…rNumberPadBar display logic
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e03060231e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
some unrelated files were caught on code cleanup commit, probably buy some lint waring. I ca revert them if necessary for tidy up the PR
# Conflicts: # Bitkit/Services/Trezor/TrezorTransport.swift
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6509b08e0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| private static let defaultSavedWidgets: [SavedWidget] = [ | ||
| SavedWidget(type: .suggestions), | ||
| SavedWidget(type: .price), | ||
| SavedWidget(type: .blocks), | ||
| ] | ||
| .suggestions, .price, .blocks, .facts, .weather, .calculator, .news, | ||
| ].map { SavedWidget(type: $0, size: .default(for: $0)) } |
This comment was marked as resolved.
This comment was marked as resolved.
|
On draft for address comments |
|
Tests after fixes hidrate-updated-wallet.movwallet-drawer-navigation.movimprove-grid-reorder.mov |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e57423f93b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Description
This PR delivers the v61 in-app widgets redesign:
It also removes the now-unused per-widget preview/list/detail/edit screens.
Linked Issues/Tasks
Screenshot / Video
add-widget.mp4
fresh-wallet.mp4
all-preview-and-edit.mp4
calculator.mp4
widgets-disabled.mp4
reset-widgets.mp4
backup-widgets.mp4
QA Notes
Manual Tests
regression:WIDE calculator: keypad behavior and conversions unchanged.regression:upgrade from a build with saved widgets: existing widgets render (default wide) and the grid lays out correctly; fresh install/reset shows the new default set.Automated Checks
xcodebuild -project Bitkit.xcodeproj -scheme Bitkit -configuration Debug -destination 'platform=iOS Simulator,id=<iPhone 16>' build ONLY_ACTIVE_ARCH=YESpasses locally. Active-arch is required because the default x86_64 simulator slice fails to link the Rust FFI, unrelated to these changes.